Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds get method for vm with optional properties #311

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adds get method for vm with optional properties #311

wants to merge 5 commits into from

Conversation

abhi1693
Copy link
Contributor

@abhi1693 abhi1693 commented Oct 20, 2022 •
edited
Loading

Closes #284

waynew
waynew suggested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhi1693 similar story on this PR - are you comfortable writing the tests yourself yet?

@abhi1693
Copy link
Contributor Author

@joechainz Hi Joe, is it possible to help merge this PR? I'm not good with pytest and currently dont have an environment to write integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a way to get virtual machine properties
2 participants
@abhi1693 @waynew